Add GIL Release to flush_events in macosx backend by ksunden · Pull Request #28398 · matplotlib/matplotlib · GitHub
Skip to content

Add GIL Release to flush_events in macosx backend - #28398

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
ksunden:macos_deadlock
Jun 26, 2024
Merged

QuLogic merged 1 commit into
matplotlib:mainfrom
ksunden:macos_deadlock

Conversation

@ksunden

@ksunden ksunden commented Jun 14, 2024

Copy link
Copy Markdown
Member

Closes #28387

PR summary

This ensures that we do not get a deadlock when we try to close tabs.

PR checklist

@greglucas greglucas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @ksunden! I have verified that this works as expected locally and tried various orders of closing operations with/without tabs etc. It also does not bring back the previous segfaults.

@tacaswell tacaswell added this to the v3.9.1 milestone Jun 14, 2024
@QuLogic
QuLogic merged commit 82551e6 into matplotlib:main Jun 26, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 26, 2024
QuLogic added a commit that referenced this pull request Jun 26, 2024
…398-on-v3.9.x

Backport PR #28398 on branch v3.9.x (Add GIL Release to flush_events in macosx backend)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Can not close figure when using multiple figures on MacOS X

4 participants