{{ message }}
Unpin numpy 2, build against prerelease numpy in CIBW - #27993
Merged
Merged
Conversation
ksunden
marked this pull request as draft
March 29, 2024 17:49
Member
Author
ksunden
force-pushed
the
np_2_build
branch
4 times, most recently
from
March 30, 2024 00:07
0d87a7c to
ece8f9a
Compare
ksunden
marked this pull request as ready for review
March 30, 2024 06:21
Member
Author
|
Everything checked out locally for me (a little hard to test release wheels without images, but managed to get the majority of tests to run and the subset which fail also fail with released mpl 3.8.3 and np 1.26) Notably, the tests which were known to be problematic with np 2.0b1 and pybind11 2.11 passed on all three test setups (essentially current releases, min version, and prerelease) |
QuLogic
reviewed
Apr 1, 2024
QuLogic
approved these changes
Apr 2, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR summary
This is in preparation for an mpl prerelease of 3.8.4rc1 (built against numpy beta, hence rc)
We may wish to do the same change to the CIBW job on
main(@QuLogic thoughts?) as that will also affect the builds uploaded to nightly.I did it just for the release branch for now, in part because I needed to unpin in setup.py anyway.
PR checklist