Unpin numpy 2, build against prerelease numpy in CIBW by ksunden · Pull Request #27993 · matplotlib/matplotlib · GitHub
Skip to content

Unpin numpy 2, build against prerelease numpy in CIBW - #27993

Merged
tacaswell merged 1 commit into
matplotlib:v3.8.xfrom
ksunden:np_2_build
Apr 3, 2024
Merged

tacaswell merged 1 commit into
matplotlib:v3.8.xfrom
ksunden:np_2_build

Conversation

@ksunden

@ksunden ksunden commented Mar 29, 2024

Copy link
Copy Markdown
Member

PR summary

This is in preparation for an mpl prerelease of 3.8.4rc1 (built against numpy beta, hence rc)

We may wish to do the same change to the CIBW job on main (@QuLogic thoughts?) as that will also affect the builds uploaded to nightly.

I did it just for the release branch for now, in part because I needed to unpin in setup.py anyway.

PR checklist

@ksunden
ksunden marked this pull request as draft March 29, 2024 17:49
@ksunden ksunden added the CI: Run cibuildwheel Run wheel building tests on a PR label Mar 29, 2024
@ksunden

ksunden commented Mar 29, 2024

Copy link
Copy Markdown
Member Author

@ksunden
ksunden force-pushed the np_2_build branch 4 times, most recently from 0d87a7c to ece8f9a Compare March 30, 2024 00:07
@ksunden
ksunden marked this pull request as ready for review March 30, 2024 06:21
@ksunden

ksunden commented Mar 30, 2024

Copy link
Copy Markdown
Member Author

Everything checked out locally for me (a little hard to test release wheels without images, but managed to get the majority of tests to run and the subset which fail also fail with released mpl 3.8.3 and np 1.26)

Notably, the tests which were known to be problematic with np 2.0b1 and pybind11 2.11 passed on all three test setups (essentially current releases, min version, and prerelease)

Comment thread .github/workflows/cibuildwheel.yml Outdated
@QuLogic QuLogic added this to the v3.8.4 milestone Apr 2, 2024
@QuLogic

QuLogic commented Apr 2, 2024

Copy link
Copy Markdown
Member

@tacaswell
tacaswell merged commit e0a38c6 into matplotlib:v3.8.x Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Run cibuildwheel Run wheel building tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants