{{ message }}
MNT: fix labeller - #27694
Merged
Merged
MNT: fix labeller#27694
Conversation
story645
marked this pull request as draft
January 24, 2024 20:02
story645
marked this pull request as ready for review
January 24, 2024 20:06
Member
Member
Author
|
🤦♀️ knew I saw that somewhere |
Member
Author
|
And for checkout, maybe has to do w/ https://github.com/actions/labeler#notes-regarding-pull_request_target-event |
1 task
Member
|
I think you were looking at old docs (and the referenced issue is older than v5); the v5 ones don't mention needing a checkout. In fact, the docs say it will read from the source repo (which it has been doing all this time). And I don't think it would have any effect, as So the changes to the workflow appear superfluous, as they are just setting configuration to the defaults and adding a checkout that doesn't do anything. |
1 task
Member
Author
QuLogic
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
According to the error message and the labeler docs, I think this was a typo.
eta: also I think running into actions/labeler#628 and not sure if the fix is it needs to be fixed here and that'll fix it or combined w/ a checkout option.