{{ message }}
Remove 3.7-deprecated fontconfig api - #27574
Closed
bawejahritik wants to merge 8 commits into
Closed
Conversation
dstansby
requested changes
Dec 28, 2023
dstansby
left a comment
dstansby
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR - I've left a request to update the test intsead of removing it. Otherwise looks 👍
Member
There was a problem hiding this comment.
Instead of deleting this test, could you change the warning check to an error check? That way we can make sure the error is raised as expected.
Author
There was a problem hiding this comment.
I've added the test, please check
dstansby
approved these changes
Dec 29, 2023
dstansby
left a comment
dstansby
left a comment
Member
There was a problem hiding this comment.
Looks great! Could whoever merges this do a squash merge?
rcomer
reviewed
Dec 29, 2023
| @@ -1,7 +1,7 @@ | |||
| import pytest | |||
Member
There was a problem hiding this comment.
Since pytest is a third party library, it was above the matplotlib import following the PEP8 style guide so ideally it should stay there.
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
QuLogic
changed the title
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Removal of old and unused API that were marked as deprecated in 3.7 of Matplotlib and the corresponding test.
(issue #26865)
PR checklist