{{ message }}
Add test_fill in test_datetime.py - #27401
Merged
Merged
Conversation
I had added my virtual environment to gitignore and pushed it. Reverted back before pull request
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
QuLogic
reviewed
Nov 30, 2023
ksunden
approved these changes
Nov 30, 2023
Member
64 tasks
rawwash
approved these changes
Dec 1, 2023
rawwash
left a comment
rawwash
left a comment
Contributor
There was a problem hiding this comment.
LGTM! good job on setting the seed, this ensure the tests are consistent, and do not change with every run.
QuLogic
approved these changes
Dec 2, 2023
Member
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Added code for
test_fillintest_datetime.pyas requested in #26864Image of an output:
PR checklist