{{ message }}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect the
d[xy]values that are used on date-based axes to betimedeltarather than raw numbers (and in particular if it doesn't work that is something we should look at)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review. Unfortunately, currently the function
ax.arrowexpects thedx,dyto be in the axis units only. We have discovered another issue while implementing datetime test.Looks like this PR would be blocked meanwhile.
I have tested a minimal change here to get the timedelta working when
dx=datetime.timedelta(days=10)with the following patch.New unitless
d[xy]are computed before passing down to the functionmpatches.FancyArrow. The drawback is that we now need to import datetime object dependence into thelib/matplotlib/axes/_axes.py. Would be appreciated if you would suggest a better approach to implement the d[xy] timedelta support.