Add test_semilogx and test_semilogy tests to test_datetime by dwilliams27 · Pull Request #27320 · matplotlib/matplotlib · GitHub
Skip to content

Add test_semilogx and test_semilogy tests to test_datetime - #27320

Open
dwilliams27 wants to merge 2 commits into
matplotlib:mainfrom
dwilliams27:tst/semilog-x-y
Open

Add test_semilogx and test_semilogy tests to test_datetime#27320
dwilliams27 wants to merge 2 commits into
matplotlib:mainfrom
dwilliams27:tst/semilog-x-y

Conversation

@dwilliams27

@dwilliams27 dwilliams27 commented Nov 14, 2023

Copy link
Copy Markdown

PR summary

Adds test_semilogx and test_semilogy tests to test_datetime, resolving Axes.semilogx and Axes.semilogy in #26864

semilogx:
image
semilogy:
image

PR checklist

@dwilliams27

Copy link
Copy Markdown
Author

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@oscargus

Copy link
Copy Markdown
Member

Thanks!

I think that if one can include timedelta as well that would be great. That is, plotting the timedelta, rather than adding it (which is OK as such, but the plotting is still datetime).

(Do you agree with me that it seems like it is not properly working for dates? Not relevant for the test case writing, but these tests show that it doesn't work?)

@oscargus

Copy link
Copy Markdown
Member

Or, thinking twice, maybe one will have to use timedelta to get something sensible "log-like"? The "log-aspect" of the contemporary dates are probably rather small.

@ksunden

ksunden commented Nov 14, 2023

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting for author

Development

Successfully merging this pull request may close these issues.

3 participants