DOC: link out to troubleshooting guide in install by story645 · Pull Request #27226 · matplotlib/matplotlib · GitHub
Skip to content

DOC: link out to troubleshooting guide in install - #27226

Merged
ksunden merged 1 commit into
matplotlib:mainfrom
story645:vsenv
Oct 30, 2023
Merged

ksunden merged 1 commit into
matplotlib:mainfrom
story645:vsenv

Conversation

@story645

Copy link
Copy Markdown
Member

PR summary

Per #27168 (comment), figured it wouldn't hurt to signpost "hey, we have a troubleshooting section over there (that links to our other troubleshooting section)" Went slightly more general than that comment suggested just because there's more than just Windows mentioned in the troubleshooting guide.

Comment thread doc/devel/development_setup.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for a potential solution before filing a bug report or reaching out to us.
for a potential solution.

It reads a bit less defensive this way.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant it in the opposite - if it's not in the guide you should reach out. Let me rewrite that .

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with or without my suggested edit.

@story645 can merge at her discretion.

@tacaswell tacaswell added this to the v3.8.1 milestone Oct 30, 2023
@ksunden
ksunden merged commit b318dbf into matplotlib:main Oct 30, 2023
@lumberbot-app

lumberbot-app Bot commented Oct 30, 2023

Copy link
Copy Markdown

ksunden added a commit to ksunden/matplotlib that referenced this pull request Oct 30, 2023
story645 added a commit that referenced this pull request Oct 30, 2023
…3.8.x

Backport PR #27226 on branch v3.8.x (DOC: link out to troubleshooting guide in install)
@ksunden ksunden mentioned this pull request Nov 2, 2023
5 tasks
@story645
story645 deleted the vsenv branch May 2, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation: devdocs files in doc/devel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants