add test_plot_date in test_datetime.py by kots14 · Pull Request #27037 · matplotlib/matplotlib · GitHub
Skip to content

add test_plot_date in test_datetime.py - #27037

Merged
jklymak merged 1 commit into
matplotlib:mainfrom
kots14:axes-plot_date-unit-test-for-issue-26864
Oct 10, 2023
Merged

add test_plot_date in test_datetime.py#27037
jklymak merged 1 commit into
matplotlib:mainfrom
kots14:axes-plot_date-unit-test-for-issue-26864

Conversation

@kots14

@kots14 kots14 commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

PR summary

Adding code for test_plot_date method in test_datetime.py mentioned in #26864

Image output -
test_plot_date_image

PR checklist

@melissawm

Copy link
Copy Markdown
Member

@ksunden ksunden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of an odd one in that despite sounding like it is doing things with dates, with these inputs actually just amounts to plot (and is a discouraged method because of that)... But it works and I guess no harm in testing it like this.

(For reference, it only does anything beyond plot if xdate=True or ydate=True are passed, at which point it sets the units of the axis)

@kots14

kots14 commented Oct 10, 2023

Copy link
Copy Markdown
Contributor Author

A bit of an odd one in that despite sounding like it is doing things with dates, with these inputs actually just amounts to plot (and is a discouraged method because of that)... But it works and I guess no harm in testing it like this.

(For reference, it only does anything beyond plot if xdate=True or ydate=True are passed, at which point it sets the units of the axis)

Should I include additional tests to accommodate this in the same test? Please suggest.

@ksunden

ksunden commented Oct 10, 2023

Copy link
Copy Markdown
Member

@jklymak
jklymak merged commit 7ea11b7 into matplotlib:main Oct 10, 2023
@QuLogic QuLogic added this to the v3.9.0 milestone Oct 11, 2023
@kots14
kots14 deleted the axes-plot_date-unit-test-for-issue-26864 branch October 14, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

5 participants