{{ message }}
TST - Adding test_table() to test_datetimes.py - #26898
Closed
iandw wants to merge 5 commits into
Closed
Conversation
iandw
marked this pull request as ready for review
September 23, 2023 14:25
Member
Member
|
Maybe one can simply use the difference between the column and row heading dates as cell values? I somewhat agree with @ksunden but no harm to test this (although not obvious what could possibly break...). |
Member
|
@iandw thanks a lot for working on this, but I largely agree this isn't testing out handling of datetimes. I don't know what a reasonable test for datetimes would look like on a table as I don't think they map data to a coordinate. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Adding a new test called "test_table" inside of the test_datetimes.py that tests that the axes.table function can generate a plot with datetime arrays.
Part of issue #26859 but does not close this issue fully.
PR checklist