{{ message }}
Bump minimum NumPy version to 1.23 - #26800
Merged
Merged
Conversation
oscargus
added
Maintenance
PR: dependencies
oscargus
force-pushed
the
numpy122bump
branch
5 times, most recently
from
September 17, 2023 13:17
ffc43e7 to
5366eab
Compare
Member
Author
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Sep 27, 2023
Cherry-picked out of matplotlib#26800
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Sep 27, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Oct 3, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Oct 3, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
issamarabi
pushed a commit
to issamarabi/matplotlib
that referenced
this pull request
Oct 5, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
Vashesh08
pushed a commit
to Vashesh08/matplotlib
that referenced
this pull request
Oct 6, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
oscargus
force-pushed
the
numpy122bump
branch
from
October 15, 2023 14:02
5366eab to
9c30fb6
Compare
Member
Author
|
Seems like there are two floating-point related errors with 1.22. Since these are really small, should I just add a bit of tolerance (and a note that these are for NumPy 1..2)? An option is, I guess, to try 1.22.1 etc to see if this is a regression that was fixed. (Have checked the change log briefly, but not really sure what the underlying problem is anyway...) |
Member
|
I've had to bump tolerance on at least one of those failing tests in Fedora fedora-python@d429c3d (though I cheated a little bit and put it in the non-x86 commit). I think it's likely to be the SIMD optimization issue that we've run into with newer NumPy. |
github-actions
Bot
added
Documentation: devdocs
Member
tacaswell
approved these changes
Feb 9, 2024
QuLogic
changed the title
ksunden
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
I take it that we will stick with 1.22 for MPL 3.9. Probably we could have gone to 1.23, but I recall that we are a bit conservative here: https://numpy.org/neps/nep-0029-deprecation_policy.html
PR checklist