{{ message }}
Fixes for pycodestyle v2.11 - #26414
Merged
Merged
Conversation
6 tasks
jklymak
approved these changes
Jul 30, 2023
Member
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Member
Author
|
I assumed we would want to backport this to the doc branch as the CI is failing there too - #26413. |
This was referenced Jul 30, 2023
Member
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Aug 1, 2023
(cherry picked from commit f7a8cab)
QuLogic
added a commit
that referenced
this pull request
Aug 1, 2023
…3.7.2-doc Backport PR #26414: Fixes for pycodestyle v2.11
wavebyrd
pushed a commit
to wavebyrd/matplotlib
that referenced
this pull request
Mar 13, 2026
(cherry picked from commit f7a8cab)
wavebyrd
pushed a commit
to wavebyrd/matplotlib
that referenced
this pull request
Mar 13, 2026
…26414-on-v3.7.2-doc Backport PR matplotlib#26414: Fixes for pycodestyle v2.11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
flake8is currently failing in CI withI think this is the relevant change: PyCQA/pycodestyle#1086
In the bubble example, it looks like the type check was there just to make sure we get an array-like out of the method. We can achieve that with the keepdims keyword.
Everywhere else I just replaced
==withisas that preserves existing behaviour so seems safest. Possibly some places could have usedisinstanceinstead but I do not know if there is an advantage to changing it to that (and I also do not know those parts of the code well enough to make that call).PR checklist