backend_qt4agg: remove redundant classes. Closes #1151. by efiring · Pull Request #2629 · matplotlib/matplotlib · GitHub
Skip to content

backend_qt4agg: remove redundant classes. Closes #1151.#2629

Merged
efiring merged 1 commit into
matplotlib:masterfrom
efiring:qt4agg_remove_unneeded
Nov 30, 2013
Merged

backend_qt4agg: remove redundant classes. Closes #1151.#2629
efiring merged 1 commit into
matplotlib:masterfrom
efiring:qt4agg_remove_unneeded

Conversation

@efiring

@efiring efiring commented Nov 30, 2013

Copy link
Copy Markdown
Member

No description provided.

@tacaswell

Copy link
Copy Markdown
Member

efiring added a commit that referenced this pull request Nov 30, 2013
backend_qt4agg: remove redundant classes.  Closes #1151.
@efiring efiring merged commit f226149 into matplotlib:master Nov 30, 2013
@efiring efiring deleted the qt4agg_remove_unneeded branch November 30, 2013 18:30
@tacaswell

Copy link
Copy Markdown
Member

This probably should get an entry in api_changes.

Do we want to provide an alias to support 3rd party users who might be using it?

@tacaswell tacaswell mentioned this pull request Dec 5, 2013
9 tasks
@efiring

efiring commented Dec 5, 2013

Copy link
Copy Markdown
Member Author

@tacaswell, good point that it should have an api_changes entry; but I hope we can avoid putting in aliases.

@tacaswell

Copy link
Copy Markdown
Member

never mind, I can't read.

@tacaswell

Copy link
Copy Markdown
Member

Sorry for the noise, I miss read.

@tacaswell

Copy link
Copy Markdown
Member

And I was looking at the wrong example. We do use it in an example, http://matplotlib.org/examples/user_interfaces/embedding_in_qt4_wtoolbar.html , at least the toolbar should be depreciated gracefully.

@efiring

efiring commented Dec 10, 2013

Copy link
Copy Markdown
Member Author

tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Dec 12, 2013
Added NavigationToolbar2QTAgg back with a deprecation warning

Added entry to api_changes.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants