{{ message }}
CI: Add pre-release installs to upcoming tests - #26197
Merged
Merged
Conversation
ksunden
approved these changes
Jun 27, 2023
ksunden
left a comment
ksunden
left a comment
Member
There was a problem hiding this comment.
I was thinking about doing exactly this in #26152, hopefully this would have caught it prior to final release...
(I do think there is an argument for some things to go even further and do git installs/get more things to upload nightlies, but this is (hopefully) better than not doing any pre releases... The particular change to pyparsing was actually made a year ago, but hadn't been released yet until recently... catching that sooner may have made it easier to sort out)
Member
QuLogic
approved these changes
Jun 27, 2023
Member
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
There is a spot reserved for $PRE in the package installation command, but the environment variable doesn't appear to be set anywhere... Let's add it when we are doing our weekly scheduled runs to get other packages' pre-releases, not just the ones from pandas and numpy. Note this may cause more noise and be a little harder to track down where the issue is coming from, but seems like a good thing to do to test against other upcoming packages.