{{ message }}
MNT: optionally collect gc in memleak.py - #25500
Closed
richardsheridan wants to merge 1 commit into
Closed
Conversation
richardsheridan
force-pushed
the
memleak_no_gc_collect
branch
from
March 19, 2023 07:33
9f76be1 to
1586803
Compare
oscargus
approved these changes
Mar 19, 2023
Member
Contributor
Author
|
I figure the script should reflect the way memory grows in matplotlib, and subsequent to #23712 that means not interfering with gc heuristics. I left the gc option available since it now takes a while to observe the long term trend and someone may want to smooth out the gc bumps for a short term measurement. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Summary
Follow up to #23712. It's quite enlightening to see the effect of collecting or not collecting on this test script.