{{ message }}
Updated WebAgg JS to check and send request over wss if using HTTPS - #25039
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Member
Contributor
Author
QuLogic
approved these changes
Jan 21, 2023
QuLogic
left a comment
QuLogic
left a comment
Member
There was a problem hiding this comment.
I confirmed this worked with a Caddy reverse proxy.
ksunden
approved these changes
Jan 25, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 25, 2023
…uest over wss if using HTTPS
QuLogic
added a commit
that referenced
this pull request
Jan 25, 2023
…039-on-v3.7.x Backport PR #25039 on branch v3.7.x (Updated WebAgg JS to check and send request over wss if using HTTPS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Added a small change to the JavaScript for the WebAgg backend. The added JavaScript code will check the protocol and updated the websocket uri to
wss:ifhttps:is being used.This is to fix an issue with matplotlib running behind a reverse proxy that adds HTTPS and secure HTTP headers like HSTS. The connection to the insecure websocket i.e.
ws:is blocked by the browser with the message:PR Checklist
Documentation and Tests
Has pytest style unit tests (andN/Apytestpasses)Documentation is sphinx and numpydoc compliant (the docs should build without error).N/ANew plotting related features are documented with examples.N/ARelease Notes
New features are marked with aN/A.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/API changes are marked with aN/A.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/Release notes conform with instructions inN/Anext_whats_new/README.rstornext_api_changes/README.rstNot sure whether or not I need to update any documentation, so please let me know if I do.
Thank you