{{ message }}
Addresses issue #24618 "Road sign" boxstyle/annotation, alternative to #24697 - #24744
Closed
Abitamim wants to merge 5 commits into
Closed
Addresses issue #24618 "Road sign" boxstyle/annotation, alternative to #24697#24744Abitamim wants to merge 5 commits into
Abitamim wants to merge 5 commits into
Conversation
Member
Member
Member
|
@oscargus what do you think is left to do on this PR? |
tacaswell
reviewed
Mar 13, 2024
| greater than this is contrained to the edge values. | ||
| """ | ||
| self.pad = pad | ||
| if head_width > 10: |
Member
There was a problem hiding this comment.
This can be done as self.head_width = np.clip(head_width, 0, 10)
Member
|
We like this one better than #24618 and do mostly like the parameterization (fraction of height + angle is less ambigious than two fractional lengths) but have a couple of to-dos / concerns
|
1 task
5 tasks
5 tasks
Member
github-project-automation
Bot
moved this from Waiting for author
to Done
in First Time Contributors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR is to address the concerns raised in #24618. I've added the ability to specify "arrow_head" and "arrow_width" in the boxstyle attributes. By specifying "head_width=1" for DArrow, LArrow, or RArrow, this makes the head of the arrow flush with the top and bottom of the body.
I need advise on if this was the correct approach, or if I should try something else.
I have also added a test and documentation. I will likely have to redo all of these commit because git is messy, but I would like feedback on what I have done.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst