TST: Set explicit styles for image tests by oscargus · Pull Request #24709 · matplotlib/matplotlib · GitHub
Skip to content

TST: Set explicit styles for image tests - #24709

Closed
oscargus wants to merge 1 commit into
matplotlib:mainfrom
oscargus:teststyles
Closed

TST: Set explicit styles for image tests#24709
oscargus wants to merge 1 commit into
matplotlib:mainfrom
oscargus:teststyles

Conversation

@oscargus

@oscargus oscargus commented Dec 13, 2022

Copy link
Copy Markdown
Member

PR Summary

Change all image test styles to explicit so that it is possible to change the default at some later stage.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus

oscargus commented Dec 13, 2022

Copy link
Copy Markdown
Member Author

timhoffm
timhoffm reviewed Dec 13, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_agg.py
@image_comparison(['agg_filter.png'], remove_text=True)
# # Update style when regenerating the test image
@image_comparison(['agg_filter.png'], remove_text=True,
style=("classic", "_classic_test_patch"))

@timhoffm timhoffm Dec 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this baseline + patch style combination is a bit bulky given that we write it all over the tests. I suggest to create a _classic_test style that hard-coded merges both.

@jklymak jklymak Jan 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscargus were you going to update this? Overall I think this is a great idea...

@timhoffm timhoffm mentioned this pull request Dec 13, 2022
Closed
@jklymak
jklymak marked this pull request as draft January 30, 2023 23:29
@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions Bot added the status: inactive Marked by the “Stale” Github Action label Apr 13, 2026
@timhoffm

timhoffm commented Apr 13, 2026

Copy link
Copy Markdown
Member

@timhoffm timhoffm closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak left review comments
@timhoffm timhoffm timhoffm left review comments

Assignees

No one assigned

Labels

status: inactive Marked by the “Stale” Github Action status: needs rebase status: superseded topic: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oscargus @timhoffm @jklymak @QuLogic