Fix mask lookup in fill_between for NumPy 1.24+ by QuLogic · Pull Request #24115 · matplotlib/matplotlib · GitHub
Skip to content

Fix mask lookup in fill_between for NumPy 1.24+ - #24115

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-maskarray-np124
Oct 7, 2022
Merged

Fix mask lookup in fill_between for NumPy 1.24+#24115
timhoffm merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-maskarray-np124

Conversation

@QuLogic

@QuLogic QuLogic commented Oct 7, 2022

Copy link
Copy Markdown
Member

PR Summary

I did not bother adding any new tests, as the existing tests will already break with the latest nightly NumPy wheels.

Fixes #24106

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added this to the v3.6.1 milestone Oct 7, 2022
@oscargus

oscargus commented Oct 7, 2022

Copy link
Copy Markdown
Member

@timhoffm
timhoffm merged commit 6f137b9 into matplotlib:main Oct 7, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 7, 2022
@QuLogic
QuLogic deleted the fix-maskarray-np124 branch October 7, 2022 08:07
@QuLogic

QuLogic commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: fill_between gives IndexError with numpy 1.24.0.dev

3 participants