{{ message }}
Conversation
ejmercier
force-pushed
the
edgecolor-connector-bug
branch
from
October 3, 2022 01:34
c31fc6f to
6a67b8e
Compare
ejmercier
changed the title
Member
Author
|
Yes I can add a test. Is there a specific place where I should create it? |
Member
|
I think that |
QuLogic
reviewed
Oct 13, 2022
oscargus
changed the title
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Member
|
Hi @ejmercier are you still interested in working on this one? It looks like it still needs a test. I'm going to mark this as "draft" for now. Please mark it as "ready for review" when you are ready. In the meantime, if you need help, feel free to ask questions here. Or you may prefer to ask them in our incubator gitter room. |
rcomer
marked this pull request as draft
January 30, 2023 19:28
Author
|
@rcomer thanks for checking up! I'm still looking to work on this. I'll plan to write the test soon and move it out of drafts! If I have any questions I'll reach out |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #23424
This bug fix forwards
**kwargsfrom the indicate_inset function into theConnection Patch. It uses a blacklist to decide which ones should be passed aspatch_kwargsto theConnection Patchand not theRectangle patch.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).