{{ message }}
New stlye qt calls#2382
Merged
Merged
Conversation
not seg-fault when using PySide Addresses issue matplotlib#2378
Member
Member
|
Oops. Forget that. 1.3.x seems fine. |
Member
|
This seems like the right thing to do -- moderizing rather than putting band-aids that work around One thing, though -- I had to do the following, or I got a segfault at startup: diff --git a/lib/matplotlib/backends/backend_qt4.py b/lib/matplotlib/backends/backend_qt4.py
index 6ae8083..991edc7 100644
--- a/lib/matplotlib/backends/backend_qt4.py
+++ b/lib/matplotlib/backends/backend_qt4.py
@@ -82,7 +82,7 @@ def _create_qApp():
if display is None or not re.search(':\d', display):
raise RuntimeError('Invalid DISPLAY variable')
- qApp = QtGui.QApplication([" "]) # probably fine, not used by QT to resolve anything
+ qApp = QtGui.QApplication([str(" ")]) # probably fine, not used by QT to resolve anything
qApp.lastWindowClosed.connect(qApp.quit)
else:
qApp = app |
Member
Author
|
There are many failures in travis from errors coming out of locale.py. |
Member
Author
|
@mdboom What OS are you testing on? I find it a bit worrying that I was not getting segfaults without that last change. |
Member
|
I'm on Fedora 19, which has pyside 1.1.0 installed from the standard package (and this is Python 2.7). |
Member
Author
|
Does this need anything else to get merged? |
Member
|
Nope. Merging. |
Member
Author
|
It doesn't look like this actually got merged, just closed. |
Member
This was referenced Nov 23, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed all qt calls to 'new style' due to a bug in PySide (see #2378)
In the course of this I discovered that there was some funny merging/un-merging of the patches from @mspacek that resulted in there being no
col2hexdefined. It may be worth a separate issue to make sure nothing else got lost.Everything seems to work, but I could not figure out how to get the font editor dialog to come up (I suspect that the italics and bold labels won't show up).
Also includes a bunch of pep8 cleanup