MNT: Remove unused imports by oscargus · Pull Request #23554 · matplotlib/matplotlib · GitHub
Skip to content

MNT: Remove unused imports - #23554

Merged
anntzer merged 4 commits into
matplotlib:mainfrom
oscargus:unusedimports
Aug 18, 2022
Merged

MNT: Remove unused imports#23554
anntzer merged 4 commits into
matplotlib:mainfrom
oscargus:unusedimports

Conversation

@oscargus

@oscargus oscargus commented Aug 4, 2022

Copy link
Copy Markdown
Member

PR Summary

Found some unused imports.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic

QuLogic commented Aug 4, 2022

Copy link
Copy Markdown
Member

@oscargus

oscargus commented Aug 4, 2022

Copy link
Copy Markdown
Member Author

It looks like this is caused by this blanket exception; perhaps that can be removed now?

There are still unused imports in backends, but ones that I believe are required, like the FigureManagers etc. I guess one can mark the lines, which I am strongly in favour of instead of the file, but it will take some time...

@anntzer

anntzer commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Perhaps you can remove F401 for all backends from .flake8 (and put in a more targeted exclusion if needed)?

@oscargus

oscargus commented Aug 4, 2022

Copy link
Copy Markdown
Member Author

New change where I started to use __all__, which seems like it hasn't been used earlier. For some files it is a bit of a hassle, so I selected the relatively easy ones.

There is a minor risk for breakage. For example, it is in current main possible to import numpy as:

from matplotlib.tri import np

This is no longer possible after this change.

oscargus
oscargus commented Aug 4, 2022
View reviewed changes
Comment thread lib/mpl_toolkits/axisartist/axislines.py
from matplotlib.path import Path
from mpl_toolkits.axes_grid1 import mpl_axes
from .axisline_style import AxislineStyle
from .axisline_style import AxislineStyle # noqa

@oscargus oscargus Aug 4, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one should deprecate this? Not sure if someone is actually importing it from here?

@oscargus
oscargus marked this pull request as draft August 4, 2022 21:43
@oscargus

oscargus commented Aug 4, 2022

Copy link
Copy Markdown
Member Author

@QuLogic
QuLogic self-requested a review August 4, 2022 21:50
@oscargus
oscargus marked this pull request as ready for review August 5, 2022 13:03
@tacaswell tacaswell added this to the v3.6.0 milestone Aug 5, 2022
@oscargus oscargus mentioned this pull request Aug 5, 2022
Closed
2 tasks
QuLogic
QuLogic approved these changes Aug 10, 2022
View reviewed changes
Comment thread lib/matplotlib/tri/__init__.py Outdated
@anntzer
anntzer merged commit 23100c4 into matplotlib:main Aug 18, 2022
@oscargus
oscargus deleted the unusedimports branch August 18, 2022 20:28
@oscargus oscargus mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes
@anntzer anntzer anntzer approved these changes

Assignees

No one assigned

Labels

Maintenance

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@oscargus @QuLogic @anntzer @tacaswell