{{ message }}
Improve mpl_toolkit documentation - #23536
Merged
Merged
Conversation
oscargus
force-pushed
the
mpltoolkitdocs
branch
6 times, most recently
from
August 2, 2022 10:21
0f066c3 to
cc71611
Compare
oscargus
marked this pull request as ready for review
August 2, 2022 10:21
QuLogic
reviewed
Aug 4, 2022
QuLogic
left a comment
Member
There was a problem hiding this comment.
BTW, haven't commented everywhere, but I think there's no need to do ~.ClassName, as the ~ trims the displayed name as specified, so there's nothing to trim. It'd only have an effect if you did, e.g., ~.module.ClassName.
timhoffm
reviewed
Aug 4, 2022
oscargus
force-pushed
the
mpltoolkitdocs
branch
from
August 8, 2022 21:52
cc71611 to
2321fb7
Compare
oscargus
marked this pull request as draft
August 8, 2022 22:23
oscargus
force-pushed
the
mpltoolkitdocs
branch
4 times, most recently
from
August 17, 2022 09:15
e88ef90 to
14b3aaf
Compare
oscargus
marked this pull request as ready for review
August 17, 2022 09:17
Member
Author
oscargus
force-pushed
the
mpltoolkitdocs
branch
from
August 18, 2022 09:33
14b3aaf to
a7151fe
Compare
Member
|
I don't think we need extra separation when referencing types in |
Member
timhoffm
reviewed
Sep 24, 2022
oscargus
force-pushed
the
mpltoolkitdocs
branch
4 times, most recently
from
October 15, 2022 22:01
342d48d to
b95b4ab
Compare
timhoffm
approved these changes
Oct 15, 2022
timhoffm
left a comment
Member
There was a problem hiding this comment.
There are code cleanups in here, which makes this require 2 approvals.
oscargus
force-pushed
the
mpltoolkitdocs
branch
from
October 15, 2022 23:01
b95b4ab to
c28cccd
Compare
QuLogic
reviewed
Oct 20, 2022
oscargus
force-pushed
the
mpltoolkitdocs
branch
from
October 20, 2022 13:00
c28cccd to
88dfcef
Compare
QuLogic
reviewed
Oct 21, 2022
oscargus
force-pushed
the
mpltoolkitdocs
branch
2 times, most recently
from
October 21, 2022 10:16
6c09ea0 to
1b4f2f7
Compare
oscargus
force-pushed
the
mpltoolkitdocs
branch
from
October 21, 2022 10:19
1b4f2f7 to
df6f957
Compare
QuLogic
approved these changes
Oct 21, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
A bit of links and numpydocifying.
(Probably won't work at the first attempt as I cannot build locally...)
And a minor change in the code for efficiency.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).