{{ message }}
Add blitting support to button widgets - #23457
Merged
Merged
Conversation
Member
Author
Member
Author
|
Rebased to work with |
anntzer
reviewed
Nov 29, 2022
Contributor
|
Looks good, but perhaps this should wait for #24474 to be merged first (and blitting adapted to the new checkboxes as well)? |
anntzer
reviewed
Dec 28, 2022
| if self.drawon: | ||
| self.ax.figure.canvas.draw() | ||
| if self._useblit: | ||
| self.ax.draw_artist(self.ax) |
Contributor
There was a problem hiding this comment.
Can you confirm that Button doesn't use copy_from_bbox/restore_region like the other two widgets because the button covers the entire axes anyways?
Member
Author
There was a problem hiding this comment.
Yes, and it's strictly a rectangle, so copy_from_bbox/restore_region would effectively be directly overwritten immediately.
anntzer
approved these changes
Dec 28, 2022
Member
Author
|
I also wonder if the default should be |
6 tasks
Contributor
greglucas
approved these changes
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).