{{ message }}
BLD: Define PyErr_SetFromWindowsErr on Cygwin. - #23066
Merged
anntzer merged 2 commits intoJul 26, 2022
Merged
Conversation
This function is defined on Windows, not Cygwin. Should maybe request that upstream.
anntzer
reviewed
May 18, 2022
Contributor
I didn't notice that PyErr_SetString returned void. This should return something normal.
DWesl
changed the title
Contributor
Author
|
It looks like enabling the Windows code in |
Contributor
|
No hurries. |
Contributor
Author
|
It looks like it compiles, but it's a bit tricky to get useful test results with the system FreeType, rather than specifically FreeType 2.6.1 |
Member
jklymak
marked this pull request as draft
June 30, 2022 09:10
QuLogic
approved these changes
Jul 26, 2022
QuLogic
left a comment
QuLogic
left a comment
Member
There was a problem hiding this comment.
This successfully fixes build on Cygwin; not sure there is anything else that really needs to be done.
QuLogic
marked this pull request as ready for review
July 26, 2022 04:05
6 tasks
anntzer
approved these changes
Jul 26, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 26, 2022
QuLogic
added a commit
that referenced
this pull request
Jul 26, 2022
…066-on-v3.5.x Backport PR #23066 on branch v3.5.x (BLD: Define PyErr_SetFromWindowsErr on Cygwin.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Define
PyErr_SetFromWindowsErron Cygwin. This function is defined on Windows, not Cygwin.Closes #22997.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).