{{ message }}
MNT: Skip existing wheels during nightly wheel upload - #22759
Merged
oscargus merged 2 commits intoApr 3, 2022
Merged
Conversation
Add the '--skip-existing' option for anaconda upload to > Skip errors on package batch upload if it already exists This will keep the nightlies.yml workflow from erroring out if no new wheels were generated, or if a workflow is manually rerun. Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
As anaconda-client does not have any stable releases on PyPI that support the API desired for uploads, pin it to the last commit on https://github.com/Anaconda-Platform/anaconda-client known to install and work (which is the merge commit of Anaconda-Platform/anaconda-client PR 589). This is done for API stability.
matthewfeickert
force-pushed
the
ci/avoid-duplicate-uploads
branch
from
April 1, 2022 04:48
38cb779 to
4599e81
Compare
matthewfeickert
commented
Apr 1, 2022
Contributor
Author
There was a problem hiding this comment.
While this does run the risk of things breaking if this commit were to ever be removed from history, pinning it to something seems much safer then having an API break happen with no warning.
oscargus
added
CI: Run cibuildwheel
tacaswell
approved these changes
Apr 1, 2022
Member
|
I do not think we need the wheel building to run on this PR because it is only looking at artifacts it finds on the main branch, not actually making them. |
Contributor
Author
Correct. Thanks Thomas! |
oscargus
approved these changes
Apr 3, 2022
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Resolves #22757
Amends PR #22733
Add the
--skip-existingoption foranaconda uploadtoThis will keep the
nightlies.ymlworkflow from erroring out if no new wheels were generated, or if a workflow is manually rerun.As
anaconda-clientdoes not have any stable releases on PyPI that support the API desired for uploads (c.f. anaconda/anaconda-client#540), pin it to the last commit on https://github.com/Anaconda-Platform/anaconda-client known to install and work (which is the merge commit of anaconda/anaconda-client#589). This is done for API stability.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).