{{ message }}
ENH: Use rcParams savefig.directory on macosx backend - #22180
Merged
Conversation
dstansby
reviewed
Jan 10, 2022
Member
There was a problem hiding this comment.
Is it possible to add a smoke test for this in the tests?
Contributor
Author
There was a problem hiding this comment.
Unfortunately I think this is another PR that would be quite hard to add a test for because it is using the GUI :( I did a global search and didn't see any of the other backends testing this either...
Contributor
Author
There was a problem hiding this comment.
I take that back, I just pushed up a test to hijack the GUI function and return a well-defined string instead. I think that should get codecov for the Python branches at least... Still not testing the Objective-C updates, but better than nothing?
greglucas
force-pushed
the
macosx-savefig
branch
2 times, most recently
from
January 10, 2022 16:25
647451d to
bd7d627
Compare
QuLogic
reviewed
Mar 8, 2022
This adds the rcParams savefig.directory option into the macosx backend for the savefig dialog window.
greglucas
force-pushed
the
macosx-savefig
branch
from
March 8, 2022 14:19
bd7d627 to
9ed0a30
Compare
QuLogic
reviewed
Mar 9, 2022
greglucas
force-pushed
the
macosx-savefig
branch
from
March 9, 2022 23:00
9ed0a30 to
15afb44
Compare
Contributor
Author
|
Ping for a review from any mac users that want to test this out. |
tacaswell
approved these changes
Apr 11, 2022
Contributor
Author
jklymak
approved these changes
May 18, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This adds the rcParams savefig.directory option into the macosx
backend for the savefig dialog window.
Additionally cleans up some of the UTF8 string allocations in this code block.
Closes #21710
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).