{{ message }}
DOC: use mpl-sphinx-theme for navbar, social, logo - #21429
Merged
Merged
Conversation
Member
Author
jklymak
marked this pull request as draft
October 22, 2021 10:44
jklymak
force-pushed
the
doc-use-mpl-sphinx
branch
3 times, most recently
from
October 22, 2021 14:38
8a6d8b5 to
58da13c
Compare
jklymak
marked this pull request as ready for review
October 22, 2021 16:01
Member
Author
|
This works now - mol-sphinx-theme had a bug... |
jklymak
marked this pull request as draft
October 23, 2021 06:50
jklymak
force-pushed
the
doc-use-mpl-sphinx
branch
2 times, most recently
from
October 23, 2021 11:29
ebfb905 to
acaedac
Compare
jklymak
marked this pull request as ready for review
October 23, 2021 17:21
jklymak
force-pushed
the
doc-use-mpl-sphinx
branch
from
October 24, 2021 08:25
2c1b72a to
3b406ff
Compare
Member
|
The only disadvatage I see with this concept is that we don't see how the resulting pages look like when changing the mpl-sphinx-theme. After updating the theme, all downstream sites have to be rebuilt as well. |
Member
Author
|
Mpl-Sphinx-theme has a doc build. These docs are built at release time, and devdocs are built periodically. The other docs are built when changed, but we could also add a "daily" build to them all. |
timhoffm
approved these changes
Oct 24, 2021
jklymak
pushed a commit
to jklymak/matplotlib
that referenced
this pull request
Oct 25, 2021
DOC: use mpl-sphinx-theme for navbar, social, logo
jklymak
pushed a commit
to jklymak/matplotlib
that referenced
this pull request
Oct 25, 2021
DOC: use mpl-sphinx-theme for navbar, social, logo
timhoffm
added a commit
that referenced
this pull request
Oct 26, 2021
Backport #21429 from jklymak/doc-use-mpl-sphinx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Switches main site to use mpl-sphinx-theme
Note at some point we need to consider pinning this for releases.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).