{{ message }}
FIX: logic of title repositioning - #21398
Merged
Merged
Conversation
Member
jklymak
force-pushed
the
fix-title-move-logic
branch
from
October 20, 2021 20:30
12b6012 to
b0d9f30
Compare
Member
Author
dstansby
reviewed
Oct 24, 2021
dstansby
left a comment
Member
There was a problem hiding this comment.
Should get an API/behaviour change not, but looks 👍
timhoffm
approved these changes
Oct 24, 2021
timhoffm
left a comment
Member
There was a problem hiding this comment.
I'm undecided if this really needs an API change note. IMHO pure bugfixes don't need if the original behavior is obviously wrong and nobody will depend on it.
greglucas
approved these changes
Nov 23, 2021
greglucas
left a comment
Contributor
There was a problem hiding this comment.
I think this is good to go and was not changing expected behavior as evidenced by the linked bug report.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
Addresses #21394 so that the padding is consistent, if not exactly what the user wants.
Old
Note how when we sharex the title is displaced downwards, but only in the first plot, not the last one. This is inconsistent with the sharex=False behaviour, which is to manually move the axes outside the axes bounds (regardless of the users' pad argument).
We did discuss this behaviour, and decided it was OK, if less than great. Users can get around this by specifying
ymanually (i.e.y=1.0001works fine). We probably should deprecate thepadargument in favour of just asking folks to specify the title position usingy.New
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).