Shorten issue templates by timhoffm · Pull Request #20750 · matplotlib/matplotlib · GitHub
Skip to content

Shorten issue templates - #20750

Merged
tacaswell merged 1 commit into
matplotlib:mainfrom
timhoffm:doc-issue-template
Nov 14, 2021
Merged

tacaswell merged 1 commit into
matplotlib:mainfrom
timhoffm:doc-issue-template

Conversation

@timhoffm

@timhoffm timhoffm commented Jul 27, 2021

Copy link
Copy Markdown
Member

PR Summary

Followup to #20688.

The goal is to make this as concise as possible.

Previews can be seen here: https://github.com/timhoffm/matplotlib/tree/doc-issue-template/.github/ISSUE_TEMPLATE

Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
Comment on lines +41 to +44

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make this a more information box instead to differentiate from description? I'm not sure what you're trying to elicit here that's not covered by description...maybe a why do you think this bug is happening?

label: More information
description: Any other information that may be helpful in understanding this bug
placeholder: |
* Has this worked before? anything different this time?
* What are the conditions under which this bug happens? input parameters, edge cases, etc?
* any theories about what's triggering this bug?

suggested fixes is another field

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken over your suggestions (with some minor rewording) but in the description not in the placeholder.

Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
- type: input
id: operating-system
attributes:
label: Operating system

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was gonna open a PR for this, but since you're tweaking - we should be consistent about capitalization in one direction or the other (all caps, sentence case)

Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/documentation.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/feature_request.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/feature_request.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/feature_request.yml Outdated
@story645

Copy link
Copy Markdown
Member

Also on the dev docs the version isn't under the logo, so that part of the form should probably be changed too:
image

@QuLogic

QuLogic commented Jul 28, 2021

Copy link
Copy Markdown
Member

Hmm, that's problematic; it's missing from anywhere visible if you aren't on the front page.

@timhoffm

Copy link
Copy Markdown
Member Author

The permanence of the version will be resolved in the theme by the version switcher pydata/pydata-sphinx-theme#433 (comment).

Agreed that we have to adapt the wording.

@timhoffm

timhoffm commented Jul 28, 2021

Copy link
Copy Markdown
Member Author

I think most suggestions are a question of style of the field descriptions: Do we want

  • full imperative sentences or
  • short descriptive explanations?

I'm for the latter. I find the forms really off-putting. I wouldn't want to fill in many fields and then even read long context descriptions. The shorter the better.

@story645

Copy link
Copy Markdown
Member

full imperative sentences or
short descriptive explanations?

what about an alternative of clearer titles and explanations as part of the place holders. Basically I made everything imperative 'cause I didn't find the descriptions instructive.

@timhoffm

Copy link
Copy Markdown
Member Author

Clearer titles is definitively a win, where we can find them.

E.g.
image
could have "How did you install Matplotlib?" as a title and no description at all.

I was trying to remove placeholders as much as possible. Maybe it's their style (the placeholder text color is quite strong), but I have the impression that fields with a placeholder are already filled in. And empty field visually calls to be filled, with a placeholder that's lost to me.

@jklymak
jklymak marked this pull request as draft July 29, 2021 14:05
@timhoffm
timhoffm force-pushed the doc-issue-template branch 2 times, most recently from fc3e686 to 8612661 Compare November 13, 2021 23:09
@timhoffm

Copy link
Copy Markdown
Member Author

@timhoffm
timhoffm marked this pull request as ready for review November 13, 2021 23:11
Co-authored-by: hannah <story645@gmail.com>
@tacaswell
tacaswell merged commit 5d2e97e into matplotlib:main Nov 14, 2021
@timhoffm
timhoffm deleted the doc-issue-template branch November 14, 2021 21:57
@QuLogic QuLogic added this to the v3.6.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants