{{ message }}
Add directional sizing cursors - #20589
Merged
Merged
Conversation
Member
Member
Author
|
I forget about nbagg; the browser uses the cardinal directions as well (though there's also I suspect that the cardinal directions are used for toolkits that support diagonal resize cursors. For example, macOS doesn't have diagonal cursors and uses non-cardinal names. Though strangely the system does use them and the files are apparently named things like |
Member
Author
The JavaScript side is just strings and not some special type, so it's nicer to translate on the Python side. This way, we don't have to remember what the Python Enum is on the JS side.
Tested on GTK, macOS, NbAgg, Qt, and Tk.
timhoffm
approved these changes
Jul 8, 2021
jklymak
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Tested on GTK, macOS, Qt, and Tk, though for macOS, I was using VNC and couldn't see any change, so that was just a check that it didn't crash.
Also, deprecate
cursordfrom the other backends.I'm not sure about the names; as you can see all toolkits use different names:
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).