{{ message }}
Rename recently introduced parameters in SpanSelector - #20558
Merged
Merged
Conversation
QuLogic
approved these changes
Jul 1, 2021
Member
Member
This was referenced Jul 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow up to #20113.
line_props->handle_propsmaxdist->handle_grab_distancebuttonsdrag_from_anywhereonselectHeads up: I also see a naming issue with
interactive(see #20113 (comment)), but it's unclear if we should go back to the oldspan_stayor a different new name. To be discussed in tomorrows dev call. This can be addressed separately from this PR.