{{ message }}
[without findfont diff] Parsing all families in font_manager - #20549
Closed
aitikgupta wants to merge 8 commits into
Closed
aitikgupta wants to merge 8 commits into
aitikgupta wants to merge 8 commits into
Conversation
7 tasks
jklymak
marked this pull request as draft
July 4, 2021 21:46
jkseppan
reviewed
Jul 11, 2021
jkseppan
reviewed
Jul 11, 2021
jkseppan
reviewed
Jul 11, 2021
jkseppan
reviewed
Jul 11, 2021
jkseppan
reviewed
Jul 11, 2021
jkseppan
reviewed
Jul 11, 2021
jkseppan
reviewed
Jul 11, 2021
jkseppan
reviewed
Jul 11, 2021
Member
Contributor
Author
|
^^ Drop in the whole workflow/idea behind the per-glyph font fallback (not a lot of details, but on a user's perspective) |
Contributor
Author
|
Things yet to complete:
Apart from these, this PR could still use a re-review (because a major chunk of changes requested were based on |
aitikgupta
force-pushed
the
family-parsing
branch
from
July 18, 2021 16:27
06913db to
3855f6c
Compare
aitikgupta
force-pushed
the
family-parsing
branch
from
July 19, 2021 08:11
3855f6c to
6ffc56e
Compare
tacaswell
reviewed
Jul 20, 2021
|
|
||
| How does Matplotlib achieve this? | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| Well, Matplotlib doesn't achieve this, *yet*. It was initially only designed to |
Member
There was a problem hiding this comment.
We aim for the writing in the docs to be more formal.
[We also discussed this on the phone]
tacaswell
reviewed
Jul 20, 2021
| prop, fontext, directory, fallback_to_default, rebuild_if_missing, | ||
| rc_params) | ||
|
|
||
| def find_fontsprop(self, prop, fontext='ttf', directory=None, |
Member
There was a problem hiding this comment.
We talked on the phone about renaming this. The should invoke that is is going at a) find multiple fonts b) that the order of the returned fonts matters.
Contributor
Author
There was a problem hiding this comment.
Some suggestions:
find_fontsfind_orderedfontsfind_fontsdictfind_fontorderfind_fontsetfind_fontfamiliesfind_orderedfamilyfind_familyorderedfind_familiesfind_fontfamilies
7 tasks
Member
|
I am going to try rebasing this so that we capture the docs. I think the code changes were made redundent by #20740 . |
1 task
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Short Note:
This is a newer and more dynamic approach than #20496, which changed findfont's API, thus breaking a lot of backends.
A much more flexible approach would be to gradually move the different backends to
find_fontspropinstead offindfont, since the new function is built over the existing API and acts as a middleware.Quoting previous PR:
This is the beginning of migrating from Matplotlib's "Font-First" approach to a "Text-First" approach.
The very first step is to parse all families in font manager. Previously, we only parsed families until we find a font file, and the rest of the backends are accustomed to just a single font file (which needs changing)
OrderedDict would contain fonts defined by font.family
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).