{{ message }}
Remove remaining 3.3 deprecations - #20465
Merged
Merged
Conversation
QuLogic
force-pushed
the
remove-33-deprecations
branch
from
June 19, 2021 09:04
981040d to
f0aa57b
Compare
Member
Author
Member
Author
|
Also, the |
Contributor
|
I think get_sample_data can just get its message tweaked and behavior change postponed for one version? It's not as if anything was urgent. |
anntzer
approved these changes
Jun 26, 2021
timhoffm
reviewed
Jun 27, 2021
|
|
||
| ``MovieWriter`` attributes | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| * ``animation.html_args`` rcParam |
Member
There was a problem hiding this comment.
Suggested change
| * ``animation.html_args`` rcParam | |
| * The rcParam ``animation.html_args`` has been removed. |
IMHO for clarity, we should take the effort and make full sentences. Also in the following bullet points.
Member
Author
There was a problem hiding this comment.
I'm a bit lazier here because a) this is in the removal section, so it's implied, and b) I re-edit these when I put together final release notes and they may or may not be re-grouped, and then will get an overall sentence then.
|
|
||
| Path helpers | ||
| ~~~~~~~~~~~~ | ||
| * ``bezier.make_path_regular``; use ``Path.cleaned()`` (or |
QuLogic
force-pushed
the
remove-33-deprecations
branch
from
June 29, 2021 09:29
f0aa57b to
b04f1a3
Compare
timhoffm
approved these changes
Jul 1, 2021
7 tasks
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).