{{ message }}
Fix suptitle out of layout - #19805
Merged
Merged
Conversation
jklymak
added
topic: geometry manager
jklymak
force-pushed
the
fix-suptitle-out-of-layout
branch
2 times, most recently
from
March 28, 2021 06:44
a8e20f4 to
aef1db1
Compare
tacaswell
approved these changes
Mar 28, 2021
Member
Member
Author
QuLogic
reviewed
Mar 29, 2021
tacaswell
reviewed
Mar 30, 2021
jklymak
force-pushed
the
fix-suptitle-out-of-layout
branch
from
March 30, 2021 04:59
aef1db1 to
a38d94e
Compare
QuLogic
approved these changes
Mar 30, 2021
jklymak
force-pushed
the
fix-suptitle-out-of-layout
branch
from
March 30, 2021 14:33
a38d94e to
6924c26
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 30, 2021
QuLogic
added a commit
that referenced
this pull request
Mar 30, 2021
…805-on-v3.4.x Backport PR #19805 on branch v3.4.x (Fix suptitle out of layout)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes: #19803
Subtitles should not be in constrained layout if they were positioned manually because constrained layout moves them. However, in 3.4 we took them out of the layout altogether, which breaks
bbox_inches='tight'and the inline backend.Have a check for the hard-coded defaults. Maybe not the most robust, but we don't store the defaults anywhere. Could maybe store onfigureand get from there, but...Storing on the subtitle object itself works fine.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).