Changed 'python -mpip' to 'python -m pip' for consistency by chbauman · Pull Request #19739 · matplotlib/matplotlib · GitHub
Skip to content

Changed 'python -mpip' to 'python -m pip' for consistency - #19739

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
chbauman:master
Mar 21, 2021
Merged

jklymak merged 1 commit into
matplotlib:masterfrom
chbauman:master

Conversation

@chbauman

Copy link
Copy Markdown
Contributor

The top-level files INSTALL.rst and README.rst both use the version with the space between the -m and the module in the command that is executed. To be more consistent, this was changed here as well.

PR Summary

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

The top-level files INSTALL.rst and README.rst both use the version with the space between the -m and the module that is execute. To be more consistent, this was changed here as well.
@tacaswell

Copy link
Copy Markdown
Member

@tacaswell tacaswell added this to the v3.5.0 milestone Mar 18, 2021

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a weak preference for the other cases to be converted as well, but not going to block on that getting done.

@anntzer

anntzer commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

I also tend to type with no space (because why bother), but I recently found out that if the module is a dotted name, then powershell gets confused if there's no space (see the point about -Dfoo.bar=baz at https://stackoverflow.com/questions/26614969/how-can-i-pass-batch-arguments-with-dots-into-a-powershell-script), so I think teaching to always use a space is better (as it works in more cases).

@jklymak
jklymak merged commit a4a508b into matplotlib:master Mar 21, 2021
@tacaswell

Copy link
Copy Markdown
Member

Thank you for your contribute @chbauman ! Congratulations on your first (I think) Matplotlib PR 🎉 hopefully we will hear from you again.

@chbauman

Copy link
Copy Markdown
Contributor Author

Thanks, was actually my second one, but it's also the first project I am contributing to. You will certainly hear more from me.

@tacaswell

Copy link
Copy Markdown
Member

@chbauman 🐑 sorry for my mistake, but still glad to have you helping!

@QuLogic QuLogic modified the milestones: v3.5.0, v3.4.0 Mar 25, 2021
@QuLogic

QuLogic commented Mar 25, 2021

Copy link
Copy Markdown
Member

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 25, 2021
QuLogic added a commit that referenced this pull request Mar 25, 2021
…739-on-v3.4.x

Backport PR #19739 on branch v3.4.x (Changed 'python -mpip' to 'python -m pip' for consistency)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants