re-arrange mplDeprecation imports by tacaswell · Pull Request #1946 · matplotlib/matplotlib · GitHub
Skip to content

re-arrange mplDeprecation imports - #1946

Merged
efiring merged 2 commits into
matplotlib:masterfrom
tacaswell:mpldeprec_imports
Apr 29, 2013
Merged

efiring merged 2 commits into
matplotlib:masterfrom
tacaswell:mpldeprec_imports

Conversation

@tacaswell

Copy link
Copy Markdown
Member

in #1917 @NelleV requested I import mplDeprecation directly from cbook. On further investigation I found that none of the current code did that.

This PR changes the import scheme to import directly from cbook everywhere.

and changed all cases of

from matplotlib import MatplotlibDeprecationWarning as mplDeprecation

to

from cbook import mplDeprecation
@NelleV

NelleV commented Apr 25, 2013

Copy link
Copy Markdown
Member

@tacaswell

Copy link
Copy Markdown
Member Author

Should lines like

iterable = cbook.iterable
is_string_like = cbook.is_string_like
is_sequence_of_strings = cbook.is_sequence_of_strings

(from axes.py) be changed to from matplotlib.cbook import blah ?

@NelleV

NelleV commented Apr 25, 2013

Copy link
Copy Markdown
Member

I think it would be cleaner, but I think this is a question of personal taste so I'll leave it up to you.

@tacaswell

Copy link
Copy Markdown
Member Author

efiring added a commit that referenced this pull request Apr 29, 2013
re-arrange mplDeprecation imports
@efiring
efiring merged commit 3b972d6 into matplotlib:master Apr 29, 2013
@tacaswell
tacaswell deleted the mpldeprec_imports branch April 29, 2013 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants