{{ message }}
FIX: make sure scalarmappable updates are handled correctly in 3D - #18929
Merged
Merged
Conversation
tacaswell
force-pushed
the
fix_3D_scatter
branch
2 times, most recently
from
November 10, 2020 22:04
1036193 to
c9c0d38
Compare
Member
QuLogic
requested changes
Nov 11, 2020
QuLogic
left a comment
QuLogic
left a comment
Member
There was a problem hiding this comment.
Revert renames, due to the above comment. Also, unmark draft?
Member
Author
|
I did the renames because the 3D collections were inconsistent between each other. I pushed to plural to match the 2D version, will push them the other way. |
tacaswell
force-pushed
the
fix_3D_scatter
branch
from
November 11, 2020 04:13
23fd7ce to
3b4b88e
Compare
tacaswell
marked this pull request as ready for review
November 11, 2020 04:13
This was referenced Nov 11, 2020
Member
Author
|
Because we have a shortage of people to review mplot3D, this being a critical bug, and in the interest of getting 3.3.3 out @QuLogic can merge this at his discretion on a single review. |
QuLogic
reviewed
Nov 11, 2020
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
QuLogic
approved these changes
Nov 11, 2020
QuLogic
changed the title
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Nov 11, 2020
…re handled correctly in 3D
Closed
tacaswell
added a commit
that referenced
this pull request
Nov 11, 2020
…3.3.x Backport PR #18929 on branch v3.3.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Code from a debugging session on the phone with @QuLogic
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).