{{ message }}
BLD: certifi is not a run-time dependency - #18636
Merged
Merged
Conversation
Member
Member
Author
|
We shouldn't let our build details leak into user space though. If the issue is just our wheel builders we should fix it there by pre-installing like we do with numpy. I am very hesitant to do it now (because the space is still moving really fast), but eventually we are going to have to have a look at pep517 and friends.... |
Member
Author
|
now this and ##18637 are going to clash, but will deal with that when it happens. |
Member
Author
|
This one should be merged first to make the backport easier. |
timhoffm
approved these changes
Oct 2, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 2, 2020
QuLogic
added a commit
that referenced
this pull request
Oct 3, 2020
…636-on-v3.3.x Backport PR #18636 on branch v3.3.x (BLD: certifi is not a run-time dependency)
Contributor
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 6, 2020
In matplotlib#18636 we removed certifi as a runtime dependency, but it turns out we do try to use it if you read from a url in a handful of places. This makes us fail gracefully and log if we can not import certifi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #18337