{{ message }}
Go back to checking figures for their manager in destroy. - #18184
Merged
jklymak merged 2 commits intoAug 11, 2020
Merged
Conversation
tacaswell
approved these changes
Aug 5, 2020
timhoffm
reviewed
Aug 5, 2020
Member
There was a problem hiding this comment.
Can we add a comment, why we have to destroy by number?
Member
Author
There was a problem hiding this comment.
It actually works either way (manager or manager.num); it's just that the code in destroy is simpler for num, i.e., we know that cls.figs.get(manager.num) is manager because we just pulled manager from cls.figs.
timhoffm
approved these changes
Aug 5, 2020
timhoffm
left a comment
timhoffm
left a comment
Member
There was a problem hiding this comment.
Travis OSX fails. I'm unclear if the error is related to the PR.
Member
Author
|
Yea, that's weird, a restart was not effective; I'll try it out on the mac. |
Member
Author
|
It worked on the Mac Mini, so I restarted Travis again. |
QuLogic
force-pushed
the
revert-canvas-manager-destroy
branch
2 times, most recently
from
August 6, 2020 03:47
4d8e0d1 to
f65eb17
Compare
Member
Author
|
I tried increasing the timeout, which didn't work, but it's appearing on other tests now, so I've reverted that as the problem doesn't seem strictly related to this PR. |
Member
This is a partial revert of a small part of matplotlib#13581. Fixes matplotlib#18163.
We will follow up on this later, matplotlib#18213.
QuLogic
force-pushed
the
revert-canvas-manager-destroy
branch
from
August 10, 2020 20:37
f65eb17 to
db6fb4d
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 11, 2020
…anager in destroy.
QuLogic
added a commit
that referenced
this pull request
Aug 11, 2020
…184-on-v3.3.x Backport PR #18184 on branch v3.3.x (Go back to checking figures for their manager in destroy.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a partial revert of a small part of #13581.
Fixes #18163.
PR Checklist