FIX: update num2julian and julian2num by jklymak · Pull Request #18021 · matplotlib/matplotlib · GitHub
Skip to content

FIX: update num2julian and julian2num - #18021

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
jklymak:fix-update-num2julian
Jul 24, 2020
Merged

FIX: update num2julian and julian2num#18021
QuLogic merged 1 commit into
matplotlib:masterfrom
jklymak:fix-update-num2julian

Conversation

@jklymak

@jklymak jklymak commented Jul 22, 2020

Copy link
Copy Markdown
Member

PR Summary

I guess if epoch2num should be follow matplotlib epoch, then julian2num should as well...

Follow up to #17983

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@jklymak jklymak added this to the v3.3.1 milestone Jul 22, 2020
@jklymak
jklymak force-pushed the fix-update-num2julian branch 6 times, most recently from 9611ec8 to cec46b5 Compare July 22, 2020 23:19
@jklymak

jklymak commented Jul 23, 2020

Copy link
Copy Markdown
Member Author

timhoffm
timhoffm reviewed Jul 23, 2020
View reviewed changes
Comment thread setup.cfg.template Outdated
Comment thread lib/matplotlib/dates.py Outdated
Comment thread lib/matplotlib/dates.py Outdated
@jklymak
jklymak force-pushed the fix-update-num2julian branch 3 times, most recently from aa871f8 to 97d1685 Compare July 23, 2020 21:16
QuLogic
QuLogic reviewed Jul 24, 2020
View reviewed changes

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor stuff.

Comment thread doc/api/next_api_changes/deprecations/17983-JMK.rst Outdated
Comment thread lib/matplotlib/dates.py Outdated
timhoffm
timhoffm approved these changes Jul 24, 2020
View reviewed changes

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on doc build fix.

@jklymak @QuLogic
FIX: update num2julian and julian2num
4757d98 
Apply suggestions from code review

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@jklymak
jklymak force-pushed the fix-update-num2julian branch from 9c20006 to 4757d98 Compare July 24, 2020 14:20
@QuLogic
QuLogic merged commit 4b179b9 into matplotlib:master Jul 24, 2020
@lumberbot-app

lumberbot-app Bot commented Jul 24, 2020

Copy link
Copy Markdown

jklymak pushed a commit to jklymak/matplotlib that referenced this pull request Jul 24, 2020
@QuLogic @jklymak
Backport PR matplotlib#18021: FIX: update num2julian and julian2num
f4606b1
@jklymak
jklymak deleted the fix-update-num2julian branch July 24, 2020 21:34
QuLogic added a commit that referenced this pull request Jul 24, 2020
@QuLogic
Merge pull request #18053 from jklymak/auto-backport-of-pr-18021-on-v…
daf999e 
…3.3.x

Backport PR #18021: FIX: update num2julian and julian2num
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes
@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

topic: date handling

Projects

None yet

Milestone

v3.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jklymak @QuLogic @timhoffm