Various cleanups to macosx backend. by anntzer · Pull Request #17702 · matplotlib/matplotlib · GitHub
Skip to content

Various cleanups to macosx backend. - #17702

Closed
anntzer wants to merge 1 commit into
matplotlib:mainfrom
anntzer:macosxclean
Closed

Various cleanups to macosx backend.#17702
anntzer wants to merge 1 commit into
matplotlib:mainfrom
anntzer:macosxclean

Conversation

@anntzer

@anntzer anntzer commented Jun 20, 2020

Copy link
Copy Markdown
Contributor

PR Summary

... noted while working on #17687...

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.4.0 milestone Jun 22, 2020
tacaswell
tacaswell reviewed Jun 22, 2020
View reviewed changes

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all seem fine to me, but would like the 2 reviewers on this to me regular mac users.

QuLogic
QuLogic reviewed Jun 23, 2020
View reviewed changes
Comment thread src/_macosx.m Outdated
Comment thread src/_macosx.m Outdated
Comment thread src/_macosx.m
Comment thread src/_macosx.m Outdated
Comment thread src/_macosx.m Outdated
Comment thread src/_macosx.m Outdated
Comment thread src/_macosx.m Outdated
@anntzer
anntzer force-pushed the macosxclean branch 3 times, most recently from e35473a to fe9c20c Compare June 23, 2020 07:42
QuLogic
QuLogic reviewed Jun 25, 2020
View reviewed changes
Comment thread src/_macosx.m Outdated
Comment thread lib/matplotlib/backends/backend_macosx.py
@jkseppan

jkseppan commented Jul 30, 2020

Copy link
Copy Markdown
Member

@anntzer

anntzer commented Jul 30, 2020

Copy link
Copy Markdown
Contributor Author

Thanks, and noted; I'll check it later.

@jklymak
jklymak marked this pull request as draft August 24, 2020 15:00
@QuLogic QuLogic modified the milestones: v3.4.0, v3.5.0 Jan 21, 2021
@QuLogic QuLogic modified the milestones: v3.5.0, v3.6.0 Aug 23, 2021
@anntzer

anntzer commented Nov 23, 2021

Copy link
Copy Markdown
Contributor Author

@anntzer anntzer closed this Nov 23, 2021
@anntzer
anntzer deleted the macosxclean branch November 23, 2021 18:17
@QuLogic QuLogic removed this from the v3.6.0 milestone Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell left review comments
@QuLogic QuLogic QuLogic approved these changes

Assignees

No one assigned

Labels

Maintenance OS: Apple status: needs revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anntzer @jkseppan @tacaswell @QuLogic