{{ message }}
Mnt drop py36 - #17662
Merged
Merged
Mnt drop py36#17662
Conversation
tacaswell
force-pushed
the
mnt_drop_py36
branch
4 times, most recently
from
June 19, 2020 22:01
32ae2c1 to
0d0e88c
Compare
tacaswell
marked this pull request as ready for review
June 28, 2020 22:05
Member
Author
tacaswell
added
the
Release critical
anntzer
approved these changes
Jun 29, 2020
Contributor
|
(prefer this being squashed) |
Member
Author
|
I left each minimum version change as its own commit but squashed the CI thrashing. |
QuLogic
reviewed
Jun 30, 2020
| EXTRAREQS: "-r requirements/testing/travis_extra.txt" | ||
| - PYTHON_VERSION: "3.7" | ||
| - PYTHON_VERSION: "3.8" | ||
| CONDA_INSTALL_LOCN: "C:\\Miniconda37-x64" |
Member
There was a problem hiding this comment.
Suggested change
| CONDA_INSTALL_LOCN: "C:\\Miniconda37-x64" | |
| CONDA_INSTALL_LOCN: "C:\\Miniconda38-x64" |
Member
Author
There was a problem hiding this comment.
This doesn't work unless we update the windows image we are using.
| # For building, use a new environment | ||
| - conda create -q -n test-environment python=%PYTHON_VERSION% tk | ||
| - activate test-environment | ||
| # pull pywin32 from conda because on py38 there is something wrong with finding |
Member
There was a problem hiding this comment.
Is that because of wrong conda above?
Member
Author
There was a problem hiding this comment.
I don't think so, we are still ending up with a py38 env and it should be de-coupled from Python version of the "base" conda enivorment. I think this has to do with Python tightening up its rules about how dlls are discovered. There are a bunch of related issues on the pywin32 issues tracker.
tacaswell
force-pushed
the
mnt_drop_py36
branch
3 times, most recently
from
July 3, 2020 01:33
a8f1e20 to
924e1cf
Compare
Member
This was release in March 2018 and is the first version of python-dateutil that does not have deprecation warnings due to the collections -> collections.abc change in CPython.
This is released in Sept 2018 and is the earliest version to not warn due to the collections -> collections.abc change in CPython.
This is consistent with our policy and NEP29
dstansby
approved these changes
Jul 6, 2020
timhoffm
approved these changes
Jul 6, 2020
2 tasks
This was referenced Dec 17, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Drop support for py36
closes #17652
PR Checklist
This should not go in until after we branch v3.3.x off of master and still needs an API change note added (but I want to let the dust settle on the renaming / moving associated with 3.3 before doing that.