Implement set_history_buttons for Tk toolbar. by QuLogic · Pull Request #17200 · matplotlib/matplotlib · GitHub
Skip to content

Implement set_history_buttons for Tk toolbar. - #17200

Merged
anntzer merged 1 commit into
matplotlib:masterfrom
QuLogic:tk-history
May 1, 2020
Merged

anntzer merged 1 commit into
matplotlib:masterfrom
QuLogic:tk-history

Conversation

@QuLogic

@QuLogic QuLogic commented Apr 20, 2020

Copy link
Copy Markdown
Member

PR Summary

This makes the backward/forward buttons change enabled state based on whether there are actually old/new views available.

This depends on #17111 because otherwise self._buttons is not initialized early enough.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Comment thread lib/matplotlib/backends/_backend_tk.py Outdated
@timhoffm

timhoffm commented May 1, 2020

Copy link
Copy Markdown
Member

This makes the backward/forward buttons change enabled state based on
whether there are actually old/new views available.

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone can merge postci

@anntzer
anntzer merged commit 5fed060 into matplotlib:master May 1, 2020
@QuLogic
QuLogic deleted the tk-history branch May 1, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants