{{ message }}
Line2d window extents - #17199
Draft
brunobeltran wants to merge 2 commits into
Draft
Line2d window extents#17199brunobeltran wants to merge 2 commits into
brunobeltran wants to merge 2 commits into
Conversation
brunobeltran
force-pushed
the
line2d-window-extents
branch
2 times, most recently
from
April 20, 2020 15:06
2d605c6 to
812f938
Compare
brunobeltran
force-pushed
the
line2d-window-extents
branch
from
June 22, 2020 19:12
812f938 to
543929b
Compare
github-actions
Bot
added
the
status: inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Goes on top of #17198. Only the "latest" commit of the two belongs to this PR.
WIP. Fix
Line2D.get_window_extent. Supercedes the discussion in #16607. Still fixes #16606, but also accounts for line joins, caps, etc, and with much less code, thanks to updates toPath.PR Checklist