Move linting to GitHub Actions with reviewdog.#17143
Conversation
|
@tacaswell ran a test PR for me here: QuLogic#5 Unfortunately, PRs don't get writable tokens for Checks API, so it won't post its separate Check with the annotation like in my test. That's a bit disappointing, but at least it's not hidden inside Travis checks now. There are a couple of other token/review options that I will check, but if none is better, I'll rename some of the stages to make it more obvious what to look at on error. |
|
Ah wait, I'm totally blind. The fallback annotations do show up; they just aren't on the sub-job, but the top-level "Linting" section. |
|
If you're looking for spellchecking in code, you can also look at codespell. |
|
I ran codespell and opened #17184, though there are still several false positives that might impede enabling it on PRs immediately. |
|
Is there still something to do on this PR or can it be merged? |

PR Summary
This moves
flake8from Travis to GitHub Actions using reviewdog to post it to the GitHub Checks. It runs a bit faster now (basically all time is runningflake8vs ~0 install time) at ~1m vs ~5.5m on Travis.Linting will appear as a section separate from Travis now in the Checks section of the PR, but I could switch the config to post a review.
Here is the PR I'm using to test out the results.
PR Checklist