{{ message }}
Fix missing parameter initialization in Axes.specgram() - #16947
Merged
Merged
Conversation
tacaswell
reviewed
Mar 30, 2020
tacaswell
approved these changes
Mar 30, 2020
tacaswell
left a comment
tacaswell
left a comment
Member
There was a problem hiding this comment.
modulo fixing the style issue.
Member
timhoffm
reviewed
Mar 31, 2020
timhoffm
changed the title
timhoffm
reviewed
Apr 2, 2020
timhoffm
approved these changes
Apr 2, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Added check to set Fs in _axes.specgram() to be Fs = freq[-1] * 2.
Added a test to test_axes.py to check if Fs is None that it won't throw an error.
Closes #9100
PR Checklist