{{ message }}
Path length - #16888
Open
brunobeltran wants to merge 2 commits into
Open
Path length#16888brunobeltran wants to merge 2 commits into
brunobeltran wants to merge 2 commits into
Conversation
This was referenced Mar 23, 2020
Closed
brunobeltran
force-pushed
the
path_length
branch
from
March 23, 2020 23:27
aca0710 to
7c72a61
Compare
brunobeltran
force-pushed
the
path_length
branch
9 times, most recently
from
March 31, 2020 02:03
e2f403a to
8d1e757
Compare
brunobeltran
force-pushed
the
path_length
branch
3 times, most recently
from
April 9, 2020 05:01
23ffc9f to
0dbef92
Compare
brunobeltran
force-pushed
the
path_length
branch
from
April 20, 2020 03:05
0dbef92 to
caf0324
Compare
jklymak
marked this pull request as draft
July 23, 2020 03:17
github-actions
Bot
added
the
status: inactive
Member
|
@brunobeltran your work on these path PRs was great. Appreciate that you have a real job now, but if you have any time to finish them, it would be a real service. Maybe your company allows donated hours? |
github-actions
Bot
removed
the
status: inactive
|
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
github-actions
Bot
added
the
status: inactive
Contributor
story645
added
topic: path handling
status: orphaned PR
keep
greglucas
force-pushed
the
path_length
branch
from
October 29, 2024 22:40
caf0324 to
bf53eaf
Compare
greglucas
force-pushed
the
path_length
branch
2 times, most recently
from
October 30, 2024 15:36
4c50daf to
5c89fb3
Compare
greglucas
marked this pull request as ready for review
October 30, 2024 15:39
greglucas
force-pushed
the
path_length
branch
from
October 30, 2024 15:50
5c89fb3 to
21baf8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
To correctly compute the center of mass of a path (to e.g. center a marker correctly), we need to correctly compute the path lengths of the component Bezier curves.
Roadmap:
#16812 (*) <- #16832 (*) <- #16859 (*) <- (This PR) (*) <- #16889 (*) <- #16891 (MarkerStyle improvements!)
"<-" means "depends on", and "(*)" marks PRs whose implementations are complete and fully ready for review.
PR Checklist