Expire deprecation of \stackrel by anntzer · Pull Request #16206 · matplotlib/matplotlib · GitHub
Skip to content

Expire deprecation of \stackrel - #16206

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:unstackrel
Feb 8, 2020
Merged

tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:unstackrel

Conversation

@anntzer

@anntzer anntzer commented Jan 13, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Like #16204, but for \stackrel.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added API: changes Changes to the public API, typically requiring deprecation. topic: text/mathtext Maintenance labels Jan 13, 2020
@anntzer anntzer added this to the v3.3.0 milestone Jan 13, 2020
@codecov

codecov Bot commented Feb 7, 2020

Copy link
Copy Markdown

@@ -93,7 +93,6 @@
r'$\operatorname{cos} x$', # github issue #553
r'$\sum _{\genfrac{}{}{0}{}{0\leq i\leq m}{0<j<n}}P\left(i,j\right)$',
r"$\left\Vert a \right\Vert \left\vert b \right\vert \left| a \right| \left\| b\right\| \Vert a \Vert \vert b \vert$",
r'$\mathring{A} \stackrel{\circ}{A} \AA$',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave in the test as r'$\mathring{A} \AA$', ? I don't think we other wise have coverage of those symbols and it will avoid the re-numbering of the tests which is very confusing.

If we really want to drop this test, we should leave a None in place and filter it a bit farther down just before we feed paramaterize.

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have an idea on how to avoid re-numbering everything

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only modify the test.

@anntzer

anntzer commented Feb 8, 2020

Copy link
Copy Markdown
Contributor Author

@tacaswell
tacaswell merged commit 85fd1ab into matplotlib:master Feb 8, 2020
@anntzer
anntzer deleted the unstackrel branch February 8, 2020 17:17
@anntzer anntzer mentioned this pull request Feb 8, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: changes Changes to the public API, typically requiring deprecation. Maintenance topic: text/mathtext

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants