Fix OSX build on azure by timhoffm · Pull Request #15429 · matplotlib/matplotlib · GitHub
Skip to content

Fix OSX build on azure - #15429

Merged
jklymak merged 2 commits into
matplotlib:masterfrom
timhoffm:fix-azure-osx
Oct 16, 2019
Merged

Fix OSX build on azure#15429
jklymak merged 2 commits into
matplotlib:masterfrom
timhoffm:fix-azure-osx

Conversation

@timhoffm

@timhoffm timhoffm commented Oct 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Current OSX pipeline fails with

🍺  /usr/local/Cellar/imagemagick/7.0.8-68: 1,479 files, 23.5MB
imlib2: XQuartz 2.7.11 (or newer) is required to install this formula. X11Requirement unsatisfied!
You can install with Homebrew Cask:
  brew cask install xquartz
You can download from:
  https://xquartz.macosforge.org
Error: An unsatisfied requirement failed this build.
##[error]Bash exited with code '1'.

This is an attempt to fix that. Not sure it will work, but let's see what Azure thinks.

@jklymak

jklymak commented Oct 16, 2019

Copy link
Copy Markdown
Member

@jklymak

jklymak commented Oct 16, 2019

Copy link
Copy Markdown
Member

mplayer doesn't have a conda recipe, but I'm a little flummoxed why we need that; its only mentioned in travis.yml, and nowhere else in the code base. Everything else has a conda recipe.

@jklymak

jklymak commented Oct 16, 2019

Copy link
Copy Markdown
Member

Oh, hmm, my apologies I see we don't use conda for these builds. Sorry for the noise. I'm also not sure what's going on. Do the macOS nodes have Xcode etc?

@timhoffm

timhoffm commented Oct 16, 2019

Copy link
Copy Markdown
Member Author

🎉 I approve too. I cannot formally push the button even though this does not contain my code anymore because this is my PR. 😏

Note: The failing windows build is a diffent issue that seems to be numpy-related:

    setuptools.sandbox.SandboxViolation: SandboxViolation: mkdir('C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\easy_install-9z1ad109\\numpy-1.17.2\\build', 511) {}
    
    The package setup script has attempted to modify files on your system
    that are not within the EasyInstall build area, and has been aborted.
    
    This package cannot be safely installed by EasyInstall, and may not
    support alternate installation locations even if you run its setup
    script by hand.  Please inform the package's author and the EasyInstall
    maintainers to find out if a fix or workaround is available.

@jklymak
jklymak merged commit a1c977a into matplotlib:master Oct 16, 2019
@tacaswell tacaswell added this to the v3.3.0 milestone Oct 16, 2019
@timhoffm
timhoffm deleted the fix-azure-osx branch October 16, 2019 23:17
@tacaswell tacaswell mentioned this pull request Oct 19, 2019
Merged
@tacaswell tacaswell modified the milestones: v3.3.0, v3.2.0 Oct 28, 2019
@tacaswell

tacaswell commented Oct 28, 2019

Copy link
Copy Markdown
Member

@meeseekdev backport to v3.2.x

@tacaswell

tacaswell commented Oct 28, 2019

Copy link
Copy Markdown
Member

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 28, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 28, 2019
@jklymak MeeseeksDev[bot]
Backport PR matplotlib#15429: Fix OSX build on azure
dedc7ff
dopplershift added a commit that referenced this pull request Oct 29, 2019
@dopplershift
Merge pull request #15545 from meeseeksmachine/auto-backport-of-pr-15…
b4039c6 
…429-on-v3.2.x

Backport PR #15429 on branch v3.2.x (Fix OSX build on azure)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@timhoffm @jklymak @tacaswell